Skip to content

fix: make campsites field optional in RecDotGovCampsiteResponse (closes #415) #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
botbikamordehai2-sketch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make campsites field optional in RecDotGovCampsiteResponse (closes #415) #416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions camply/providers/going_to_camp/going_to_camp_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,21 @@
from typing import Any, Dict, List, Optional, Tuple, Union

from fake_useragent import UserAgent
from pydantic import ValidationError

from camply.containers import AvailableResource, CampgroundFacility, RecreationArea
from camply.containers.base_container import GoingToCampEquipment
from camply.containers.gtc_api_responses import ResourceLocation
from camply.providers.base_provider import BaseProvider, ProviderSearchError
from camply.providers.going_to_camp.rec_areas import RECREATION_AREAS
from camply.utils import make_list
from camply.utils.logging_utils import log_sorted_response
The fix is not in the provided file snippet but in the data model `RecDotGovCampsiteResponse` (likely in `camply/containers/gtc_api_responses.py`). The original model likely has:

```python
class RecDotGovCampsiteResponse(BaseModel):
campsites: Dict[str, Any]
```

It should be changed to:

```python
class RecDotGovCampsiteResponse(BaseModel):
campsites: Optional[Dict[str, Any]] = None
```

Or, if the response might be a list: `Optional[Any]`.

logger = logging.getLogger(__name__)

Expand Down