Fix --telemetry help text to match update merge semantics#183
Merged
Conversation
A per-category telemetry update merges into the session's current selection rather than replacing it; only --telemetry=all/off reset the whole config. The update flag help said "replaces current selection" and "capture exactly those categories", which is wrong for the merge path. Also refresh the README's telemetry section, which still showed the removed name=on/off grammar, an "all categories" label for the default set, and the old --categories list. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR appears to be documentation/help text only with no behavior changes; unclear which service in the kernel mono-repo is implicated, please clarify the affected service or opt in manually if deploy monitoring is needed. To monitor this PR anyway, reply with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The telemetry CLI help and README still described the old/incorrect contract. A per-category telemetry
updatemerges into the session's current selection (only categories you name change); only--telemetry=all/offreset the whole config.Docs-only/help-text; no behavior change.
Test plan
CI
Note
Low Risk
Documentation and CLI flag help text only; no code paths or API behavior changed.
Overview
Docs-only alignment for browser telemetry on
browsers updateand in the README—no runtime changes.The
--telemetryflag help onkernel browsers updatenow states that--telemetry=allresets to the default set,--telemetry=offdisables, and comma-separated categories merge into the current selection (instead of replacing the whole config).The README Browser Telemetry section is updated the same way: clearer examples for default/on/off and per-category capture, plus an expanded
--categorieslist fortelemetry stream(control,connection,screenshot,captcha,monitor, etc.).Reviewed by Cursor Bugbot for commit e66b2f7. Bugbot is set up for automated code reviews on this repo. Configure here.