test: migrate test suite to package:checks#201
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the test assertions in the build_cli package from the traditional expect syntax to the checks library. This includes adding checks to pubspec.yaml and updating various integration tests. The review feedback suggests improving assertion clarity and error messages by refactoring a null-safe property check, removing a redundant null check on a non-nullable list, and maintaining type consistency by comparing a double value with a double literal instead of an integer.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
- Add dev_dependency on package:checks. - Refactor legacy expect() assertions to check() in all integration tests. - Enforce strict type-safety and nullability assertions.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request migrates the test suite of build_cli from using package:test/test.dart assertions to package:checks/checks.dart and package:test/scaffolding.dart. Feedback on the changes suggests removing a redundant .isNotNull() check on a non-nullable list property (options.ignorePackages) in pubviz_integration_test.dart.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request migrates the test suite in build_cli from using package:test/test.dart and expect assertions to using package:test/scaffolding.dart and package:checks/checks.dart with check assertions. The checks package has been added as a dev dependency in pubspec.yaml. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Migrates the test suite from
package:matchertopackage:checks.Verified 100% clean static analysis (
dart analyze) and all tests passing (dart test).