Skip to content

Add Capital Lekwungen Characters#4005

Open
jwarrenbc wants to merge 7 commits into
keymanapp:masterfrom
jwarrenbc:master
Open

Add Capital Lekwungen Characters#4005
jwarrenbc wants to merge 7 commits into
keymanapp:masterfrom
jwarrenbc:master

Conversation

@jwarrenbc

Copy link
Copy Markdown

Xʷsépsəm Lək̓ʷə́ŋən uses English-style capitalization. This is a change to the fv-lekwungen keyboard so that when Shift or Caps Lock is pressed, the number row switches to capital Lekwungen characters rather than numerics.

Copilot AI review requested due to automatic review settings June 3, 2026 19:08
@keyman-server

Copy link
Copy Markdown
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@jwarrenbc

Copy link
Copy Markdown
Author

Ready for review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Lekwungen (Lək̓ʷəŋən) Keyman keyboard to better support case/shift behavior for special letters, and aligns the visual keyboard with the updated shifted outputs.

Changes:

  • Expanded physical keyboard rules to explicitly handle Shift/Caps combinations for special characters (ə/Ə, ɬ/Ɬ, ŋ/Ŋ, etc.).
  • Updated the visual keyboard’s Shift layer to show the intended uppercase/special outputs.
  • Minor rule/comment updates (e.g., glottal combination support for Ŋ).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
release/fv/fv_lekwungen/source/fv_lekwungen.kvks Updates visual keyboard Shift layer to display uppercase/special outputs for the keyboard’s new case behavior.
release/fv/fv_lekwungen/source/fv_lekwungen.kmn Adds explicit Caps/Shift handling for special letters and updates a glottal-combination store.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +113 to +114
+ [SHIFT T_B] > 'ŋ' layer('default')
+ [SHIFT T_B_0] > 'ŋ̓' layer('default')
Comment on lines +1 to +2
<?xml version="1.0" encoding="utf-8"?>
<visualkeyboard>
+ [NCAPS SHIFT K_0] > 'Ŋ'
+ [CAPS SHIFT K_0] > 'ŋ'

c letters not in lekwungen but added here to be consistant with LG layout
Comment thread release/fv/fv_lekwungen/source/fv_lekwungen.kvks Outdated
@LornaSIL

Copy link
Copy Markdown
Contributor

@jwarrenbc are you officially related to First Voices? Their keyboard changes generally have to be approved by someone from the First Voices organization.

@jwarrenbc

jwarrenbc commented Jun 10, 2026 via email

Copy link
Copy Markdown
Author

@LornaSIL

Copy link
Copy Markdown
Contributor

Can you update the HISTORY.md file for what changes were made, version, date, etc. We prefer the latest changes are above the previous ones (not the bottom)

Can you update LICENSE.md to extend the copyright year: Copyright (c) 2024-2026 FirstVoices, SIL International

Otherwise it looks good. I'm glad you have the uppercase for that curled L now.

Is there someone we can get from FV to approve this? Does Rohit have a github account?

Updated keyboard layout for Lekwungen language with new versioning and layout adjustments.
Added version 1.1 with updates to the number row characters.
Updated copyright year range in LICENSE.md
@jwarrenbc

Copy link
Copy Markdown
Author

I emailed First Voices to ask someone from their tech team to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants