fix: check folder names against package names more carefully#4029
Open
mcdurdin wants to merge 1 commit into
Open
fix: check folder names against package names more carefully#4029mcdurdin wants to merge 1 commit into
mcdurdin wants to merge 1 commit into
Conversation
Fail if there exists a folder without a corresponding .kps file. Ignore empty folders or folders that contain only build/ subfolder, as these tend to get left around when switching branches. Fixes: keymanapp/keyman#16093
mcdurdin
commented
Jun 15, 2026
| fi | ||
| else | ||
| (find "$target" -maxdepth 2 -type d -wholename "$target"'/*/*' | grep -vE '^(release/packages|release/shared|release/template)' || true) >> build_targets_temp.txt | ||
| (find "$target" -maxdepth 2 -type d -wholename "$target"'/*/*' | grep -vE '^(experimental/shared|release/packages|release/shared|release/template)' || true) >> build_targets_temp.txt |
Member
Author
There was a problem hiding this comment.
Skip also experimental/shared/fonts folder
Contributor
There was a problem hiding this comment.
Comment at top of file needs to be updated
ermshiperete
approved these changes
Jun 16, 2026
| fi | ||
| else | ||
| (find "$target" -maxdepth 2 -type d -wholename "$target"'/*/*' | grep -vE '^(release/packages|release/shared|release/template)' || true) >> build_targets_temp.txt | ||
| (find "$target" -maxdepth 2 -type d -wholename "$target"'/*/*' | grep -vE '^(experimental/shared|release/packages|release/shared|release/template)' || true) >> build_targets_temp.txt |
Contributor
There was a problem hiding this comment.
Comment at top of file needs to be updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail if there exists a folder without a corresponding .kps file. Ignore empty folders or folders that contain only build/ subfolder, as these tend to get left around when switching branches.
Fixes: keymanapp/keyman#16093