auto: A19S32 merge master into staging#800
Merged
Merged
Conversation
* Update the call to `downloadSection()` in version landing pages to match the new identifiers used in ui/downloads.php. Fixes the base issue for the versioned landing pages. * Refactor `Locale::definePageScope` to declare standard `$_m_<domain>` variable and `_m_<domain>()` function, so that we can skip the Locale initialization boilerplate in more places. Also make it possible to declare multiple scopes (supporting includes in the future), and make the function idempotent. * Update references to `[$]_m*` to the common pattern provided in `Locale::definePageScope`. * Add version landing pages to _test/ so that they are crawled in the link checker. Fixes: #764 Fixes: KEYMAN-COM-3H1 Test-bot: skip
Select the most appropriate language when a top-level page is encountered, either from the user's most recently chosen language, or else from the request Accept-Language header. Install Negotiator to parse Accept-Language. Fix a bug with the 404 page where the locale would be reset secretly by unexpected requests. Remove the invalid locale redirect from Head.php because it cannot be encountered with the current htaccess patterns. Establish the use of sessions throughout the site, to allow us to track the current language server-side. This could alternately be done with a cookie. Fixes: #762 Test-bot: skip
Relates-to: #771 Test-bot: skip
Test-bot: skip
auto: refresh contributors
…ages-and-refactor-definePageScope fix: update version landing pages with new i18n references
…top-level-pages feat: select best language when redirecting to an i18nized page
fix: improve look and feel of globe icon on desktop layout
…v1.0.13 auto: update shared-sites version to v1.0.13
Fixes: #763 Test-bot: skip
Test-bot: skip
The banner is too prominent and distracts from the main flow of the page so I moved it to the bottom instead.
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Fixes: #779 Test-bot: skip
feat: add a banner where we don't have localized content
chore: funding update
…r-phone feat: collapse UI language selector on phone devices
Fixes: #783 Test-bot: skip
Add i18n of /windows/index.php. Other pages under /windows will come later. Also, add a query param `LOCALE_DEBUG` so we can easily spot untranslated strings. Fixes: #770 Test-bot: skip
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Establish Util::call_api_keyman_com and Util::call_downloads_keyman_com as common functions for making http requests to these servers. Use curl instead of file_get_contents as it is more reliable and we have more control over parameters. The pattern for now could stand to be refactored further in the future to provide API functions for each endpoint and reduce repetition and fragility. Test-bot: skip
Broken-link-checker (BLC) is basically dead -- no releases for 8 years, no updates to master for 5. The trigger for this change is, however, that BLC was not honoring exclusions on redirects, which cause sporadic errors (e.g. 429) because we hit external servers in our link test. Replace with linkinator, which is in maintenance and does the job pretty well. I have forked linkinator and added some patches specific to our environment which I may push upstream later when we are confident of the setup. Unify the ci.yml and build.sh test steps (this will need to be tested in CI once this merges to master). Test-bot: skip
The session was not automatically started when the redirect page was loaded, because it needed Locale to be touched first (due to the way autoload is resolved in PHP). Fixes: #784 Test-bot: skip
This moves to node v24. Relates-to: keymanapp/s.keyman.com#1607 Test-bot: skip
…nguage feat: highlight selected ui language
…http-requests chore: use common function for backend http requests
chore: replace broken-link-checker with linkinator
Bumps [form-data](https://github.com/form-data/form-data) from 4.0.5 to 4.0.6. - [Release notes](https://github.com/form-data/form-data/releases) - [Changelog](https://github.com/form-data/form-data/blob/master/CHANGELOG.md) - [Commits](form-data/form-data@v4.0.5...v4.0.6) --- updated-dependencies: - dependency-name: form-data dependency-version: 4.0.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Content on websites is in the keymancom project on Crowdin. Test-bot: skip
It is important that the bootstrap version is pointing to a published tag, so that merged changes do not end up pointing to an ephemeral ref on the shared-sites repository. This change splits the bootstrap version into a separate file resources/.bootstrap-required-version, so that this version string can be easily checked in ci.yml, preventing merge of pull requests that point to branch names instead of tag names. For simplicity, the test verifies the shape of the version string as 'v#.#.#', but does not verify that it actually points to a tag, so in theory it could be fooled, but in practice we never use that pattern for branch names. Test-bot: skip
chore: update multi-labeler to 5.0.0
chore: use keymancom instead of keyman for localization site
…v1.0.14 auto: update shared-sites version to v1.0.14
chore: verify bootstrap version format before merge
fix: start session in redirect handler
feat: i18n of /windows
…v1.0.15 auto: update shared-sites version to v1.0.15
Test-bot: skip
auto: refresh contributors
…ts/contributors/form-data-4.0.6 chore(deps): bump form-data from 4.0.5 to 4.0.6 in /_scripts/contributors
keyman-status
approved these changes
Jun 22, 2026
github-actions
Bot
added
the
auto
keyman-status
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-bot: skip