Drawing lots for absolute majority#3460
Merged
Merged
Conversation
Contributor
Author
|
Patch coverage is pretty low, I will add some tests to cover helpers |
stacktraceghost
previously approved these changes
Jun 24, 2026
praseodym
requested changes
Jun 24, 2026
praseodym
approved these changes
Jun 24, 2026
stacktraceghost
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Implementation details:
reassign_residual_seat_for_absolute_majority()to try and use a list fromlists_drawnwhen drawing lots is neededListDrawingLotsVariant::AbsoluteMajorityinto two variants, corresponding to a seat that is reassigned from a previous largest remainder or highest average seat changeassign_tofield to theAbsoluteMajorityDrawingLotsvariant details to be used in the frontendApportionmentError::InvalidStatevariant and use it when a previous seat change is not one of the expected variantsreassign_residual_seat_for_absolute_majority()within acceptable limitsHow to test
Unit tests are adjusted accordingly, frontend will be built in later issues from #788
Reviewer notes
Start in
backend/apportionment/src/seat_assignment/mod.rsto see the core change inreassign_residual_seat_for_absolute_majority()and what the results are in the tests below. Then check what other changes were needed to make this happen.