Add real number of voters to gen test election #3470
Merged
Merged
Conversation
… election with given votes
stacktraceghost
approved these changes
Jun 25, 2026
praseodym
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Add number of voters value between 100% and 200% of votes to gen test election with given votes instead of default 1. The value 1 is an error and needed to be corrected.
How to test
Generate P 22-2 variants or drawing lots variants and see that "Kiesgerechtigden" (in Apportionment Kengetallen table) is set to a more logical value instead of 1.
Reviewer notes