Drawing lots for candidate nominations (P 15)#3471
Merged
Conversation
oliver3
requested review from
Lionqueen94,
praseodym,
rnijveld and
stacktraceghost
oliver3
changed the title
stacktraceghost
approved these changes
Jun 25, 2026
praseodym
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
How to test
Unit test
test_with_drawing_of_lots_error()has been updated with drawing lots for candidates and asserting the resultUnit test
test_preferential_candidate_nomination_scenarios()tests multiple scenarios for candidate nomination (P 15)Frontend will be implemented in a later issue from Epic #788
Reviewer notes
Main change is in
candidate_nomination_per_list()inbackend/apportionment/src/candidate_nomination/mod.rsand I suggest starting there.Two other changes are:
CandidateNominationInput::total_seats_per_listfrom aVecto aHashMapCandidateVotesMockto a tuple struct for one-line construction, to improve test readabilityI've tried adding the
candidates_drawniterator to theCandidateNominationInputstruct instead of passing it as a separate argument, but the generics became even more complex, and also the whole input would then have to become mutable. I decided that that was not making things more clear.