You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a reversion of functionality that was added.
Describe alternatives you've considered
Reverts behavior from #1364 that stripped messages off of the judges and then re-created them.
Additional context
This was discussed and there are various concerns about this behavior. Since this is a semi-permanent solution once changes are applied on the server side we don't want to take this step yet.
Note
Medium Risk
Judge configs again expose full legacy message lists to callers, which can change runtime prompts versus the stripped behavior. The widened Runner.run signature is a public API change, though string-based call paths stay backward compatible.
Overview Reverts judge message stripping from a prior change: stripLegacyJudgeMessages, reserved-variable re-injection for message_history / response_to_evaluate, and related warnings are removed. judgeConfig now returns flag-evaluated messages unchanged (including legacy {{message_history}} / {{response_to_evaluate}} template rows).
Extends the Runner protocol so run accepts string | LDMessage[]. String inputs keep the existing behavior (config messages prepended, multi-turn history updated). A pre-built LDMessage[] is sent to the provider as-is—no config merge and no history mutation—implemented in the OpenAI, LangChain, and Vercel model runners with matching tests.
Reviewed by Cursor Bugbot for commit 1d6223b. Bugbot is set up for automated code reviews on this repo. Configure here.
@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes
@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38739 bytes
Compressed size limit: 39000
Uncompressed size: 212244 bytes
@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179579 bytes
Compressed size limit: 200000
Uncompressed size: 831422 bytes
@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31978 bytes
Compressed size limit: 34000
Uncompressed size: 114243 bytes
) now that the base runner interface can take in string | LDMessage[]?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
https://launchdarkly.atlassian.net/jira/software/c/projects/AIC/boards/2045?selectedIssue=AIC-2848
Describe the solution you've provided
This is a reversion of functionality that was added.
Describe alternatives you've considered
Reverts behavior from #1364 that stripped messages off of the judges and then re-created them.
Additional context
This was discussed and there are various concerns about this behavior. Since this is a semi-permanent solution once changes are applied on the server side we don't want to take this step yet.
Note
Medium Risk
Judge configs again expose full legacy message lists to callers, which can change runtime prompts versus the stripped behavior. The widened
Runner.runsignature is a public API change, though string-based call paths stay backward compatible.Overview
Reverts judge message stripping from a prior change:
stripLegacyJudgeMessages, reserved-variable re-injection formessage_history/response_to_evaluate, and related warnings are removed.judgeConfignow returns flag-evaluated messages unchanged (including legacy{{message_history}}/{{response_to_evaluate}}template rows).Extends the
Runnerprotocol sorunacceptsstring | LDMessage[]. String inputs keep the existing behavior (config messages prepended, multi-turn history updated). A pre-builtLDMessage[]is sent to the provider as-is—no config merge and no history mutation—implemented in the OpenAI, LangChain, and Vercel model runners with matching tests.Reviewed by Cursor Bugbot for commit 1d6223b. Bugbot is set up for automated code reviews on this repo. Configure here.