fix(server-ai): unpin peer depedency reference#1788
Conversation
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk size report |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| "typescript-eslint": "^8.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@launchdarkly/js-server-sdk-common": "2.19.2" |
There was a problem hiding this comment.
Hmm. This one is a bit more curious and I am less sure about the safety. But I assume we are probably only using safe API types from here.
There was a problem hiding this comment.
Yea I was debating what to do about this one honestly... it doesn't make much sense to me to pin peer deps and I can't really imagine how this would be used... from the package itself, it looks like it only uses LDContext, LDFlagValue, and LDLogger... so I think this should be fine.
2 participants
This PR will unpin the sdk-server-common package from the peer deps of server-ai
The server common package seems to be only used for typing. I chose a more conservative floor of 2.0.0 to match more versions. We will reassess if there are any issues with this.
Note
Low Risk
Single
package.jsonpeer range change with no runtime code; low risk unless older 2.x common releases break the typing surface server-ai relies on.Overview
@launchdarkly/server-sdk-aino longer requires an exact@launchdarkly/js-server-sdk-commonpeer version. The peer range changes from2.19.2to^2.0.0, so apps can pair server-ai with any 2.x server common release instead of being locked to one patch.The devDependency on
2.19.2is unchanged; only install-time peer resolution is affected. Server-ai still imports shared types such asLDContextandLDLoggerfrom that package.Reviewed by Cursor Bugbot for commit 1c1907b. Bugbot is set up for automated code reviews on this repo. Configure here.