Fix/video category navigation#1063
Conversation
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
|
🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1063/
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a hash-based navigation system for video categories, featuring CSS transitions and dynamic height adjustments for the video grid. The feedback identifies several areas for improvement: optimizing the Hugo template performance by using .Scratch instead of merge within loops, correcting the usage of safeHTMLAttr to ensure proper attribute escaping, and refining the JavaScript logic to preserve existing URL parameters and hashes when updating links.
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
|
@Sbragul26 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
2 participants
Notes for Reviewers
This PR fixes #1051 where opening a video category page directly always showed the "Getting Started" tab instead of the correct one. It also fixes the URL update and removes footer flicker when switching tabs. No breaking changes.
Signed commits