Conversation
this commit is generated by Codex and has a lot of issues. Do not merge this commit without carefully reviewing.
…ing handler this is a fix for the recent codex-generated commit.
…unused `boolOutput` function
…e outputs of a step This commit is generated by codex agent. Please review this changes carefully before merging.
Seasawher
changed the title
checkChanges.js in Lean with typed input validation
resolve #233 This is caused by the environment variable `LATEST_LEAN` is only set when the lake project does not have dependencies. The action see empty `LATEST_LEAN` when the project has dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the old
scripts/checkChanges.jshelper with a Lean implementation exposed as:The check now lives in
LeanUpdate.CheckChanges, alongside the rest of the action logic.Changes
scripts/checkChanges.jscheckChangescommand that checks whetherlean-toolchainorlake-manifest.jsonchangedupdate_if_modifiedinput viaUpdateIfModifiedGITHUB_ENVasLEAN_UPDATE_*valuesaction.ymlto consume those environment values instead of the removed JS step outputsNotes
Moving this logic into Lean means
UPDATE_IF_MODIFIEDis now parsed and validated by the same input handling layer as the other action inputs. Invalid values are rejected before the update decision is made.