Enable ruff isort import rules#677
Merged
Merged
Conversation
Add the "I" rule category to ruff's lint selection so import ordering is enforced again after the uv migration dropped reorder-python-imports. Configure isort to match the prior reorder-python-imports behaviour: force-single-line (one import per line) and order-by-type=false (case-insensitive alphabetical, not CapWords-first). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
One-time mechanical reformat from enabling the "I" rule category. No logic changes — only import ordering, force-single-line splitting, and normalised blank lines after import blocks. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Import-ordering enforcement was silently lost when ricecooker migrated from
reorder_python_importsto ruff — theIrule category was never added to ruff'sselect, so nothing reordered or split imports. This addsIand configures isort to reproduce the old one-per-line style (force-single-line,order-by-type = false, i.e. case-insensitive rather than CapWords-first). ricecooker had no isort config at all, so one was added.Three commits: the config change, a mechanical one-time reformat (37 files,
ruff check --fix), and a new.git-blame-ignore-revs(didn't previously exist) with the reformat.References
None — no tracking issue. Part of a cross-repo pass restoring import-ordering enforcement after the uv migrations.
Reviewer guidance
The reformat commit is purely mechanical — review the config commit for intent. The reformat is excluded from
git blamevia.git-blame-ignore-revs. Verify withruff check --select I .(clean on the branch).Each reformat diff was scanned for semantic import-order changes; none were found in this repo.
AI usage
Used Claude Code to investigate why import style was no longer enforced after the uv migration, derive the ruff isort config that reproduces the old
reorder_python_importsbehaviour, and apply it. The reformat diff was reviewed for load-bearing import-order changes before committing.