Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@ updates:
schedule:
interval: monthly
open-pull-requests-limit: 1
cooldown:
default-days: 7
12 changes: 7 additions & 5 deletions .github/workflows/boulder-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
# Sequence of tasks that will be executed as part of the job.
steps:
# Checks out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false

Expand Down Expand Up @@ -104,17 +104,18 @@ jobs:

steps:
# Checks out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false

- name: Setup Go
uses: actions/setup-go@v6
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
with:
# When Go produces a security release, we want govulncheck to run
# against the most recently released Go version.
check-latest: true
go-version: "stable"
cache: false

- name: Run govulncheck
run: go run golang.org/x/vuln/cmd/govulncheck@latest ./...
Expand All @@ -129,14 +130,15 @@ jobs:

steps:
# Checks out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false

- name: Setup Go ${{ matrix.go-version }}
uses: actions/setup-go@v6
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
with:
go-version: ${{ matrix.go-version }}
cache: false

- name: Verify vendor
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-iana-registries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ jobs:

steps:
- name: Checkout iana/data from main branch
uses: actions/checkout@v6
with:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with: # zizmor: ignore[artipacked] gh credentials must be persisted so we can open a PR
sparse-checkout: iana/data

# If the branch already exists, this will fail, which will remind us about
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false
- name: Initialize CodeQL
uses: github/codeql-action/init@v4
uses: github/codeql-action/init@7211b7c8077ea37d8641b6271f6a365a22a5fbfa # v4
- name: Autobuild
uses: github/codeql-action/autobuild@v4
uses: github/codeql-action/autobuild@7211b7c8077ea37d8641b6271f6a365a22a5fbfa # v4
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v4
uses: github/codeql-action/analyze@7211b7c8077ea37d8641b6271f6a365a22a5fbfa # v4
8 changes: 4 additions & 4 deletions .github/workflows/cps-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,20 @@ jobs:
pull-requests: write
steps:
- name: Setup Go
uses: actions/setup-go@v6
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
with:
go-version: "stable"

- name: Checkout Upstream
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false
ref: ${{ github.event.pull_request.base.ref }}
- name: Get Current Flags
run: go run ./test/list-features/list-features.go | sort >| /tmp/currflags.txt

- name: Checkout PR
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false
- name: Get PR Flags
Expand All @@ -38,7 +38,7 @@ jobs:

- name: Comment PR
if: ${{ steps.newflags.outputs.flagnames != '' }}
uses: actions/github-script@v9
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9
env:
NEW_FLAGS: ${{ steps.newflags.outputs.flagnames }}
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue-for-sre-handoff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
pull-requests: write
steps:
- name: Comment PR
uses: actions/github-script@v9
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9
with:
script: |
const commentMarker = '<!-- deployment_ticket_check -->';
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/merged-to-main-or-release-branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ jobs:
name: Merged to main (or hotfix)
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
permissions:
contents: write
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false
fetch-depth: '0' # Needed for verify-release-ancestry.sh to see origin/main
Expand All @@ -41,7 +41,7 @@ jobs:
contents: write
packages: write
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false
fetch-depth: '0' # Needed for verify-release-ancestry.sh to see origin/main
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
permissions:
contents: write
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/try-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- "1.26.3"
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false

Expand Down
42 changes: 42 additions & 0 deletions .github/workflows/zizmor.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: Lint GitHub Actions

on:
push:
branches:
- main
- release-branch-*
pull_request:
branches:
- '**'
workflow_dispatch:

permissions: {}

jobs:
zizmor:
runs-on: ubuntu-24.04

env:
ZIZMOR_VERSION: 1.25.2

steps:
- name: Checkout repository
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false

- name: Download and verify zizmor
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -euo pipefail
url="https://github.com/zizmorcore/zizmor/releases/download/v${ZIZMOR_VERSION}/zizmor-x86_64-unknown-linux-gnu.tar.gz"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zizmor docs say:

Most ordinary users should not install the binaries from zizmor's GitHub releases. Binaries are provided on a best-effort basis, and may be subject to libc and other compatibility issues.

(emphasis theirs)

It looks like fully-supported options include cargo and docker.

Perhaps it makes more sense to put zizmor in our boulder-tools image, for instance in build-rust-deps.sh?

(and yes, we still need to do some work to make boulder-tools auto-built rather than uploaded by boulder devs)

curl --fail --location --show-error --silent --output zizmor.tar.gz "${url}"
gh attestation verify zizmor.tar.gz --repo zizmorcore/zizmor
tar -xzf zizmor.tar.gz zizmor
./zizmor --version | grep -Fq "zizmor ${ZIZMOR_VERSION}"

- name: Run zizmor
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: ./zizmor .