Skip to content

CircuitBreaker spec #884

Merged
tamtamchik merged 10 commits into
mainfrom
feat/circuit-breaker
Jun 15, 2026
Merged

CircuitBreaker spec #884
tamtamchik merged 10 commits into
mainfrom
feat/circuit-breaker

Conversation

@failingtwice

Copy link
Copy Markdown
Contributor

Please, go through these steps before you request a review:

📝 Describe your changes

  1. Add a CircuitBreaker spec

🔎 Attach a source of truth or evidence that allows reviewers to confirm the changes independently

  1. https://github.com/lidofinance/lido-improvement-proposals/blob/develop/LIPS/lip-34.md

@failingtwice failingtwice requested review from a team as code owners May 6, 2026 11:23
@failingtwice failingtwice marked this pull request as draft May 6, 2026 11:23
@failingtwice failingtwice changed the title CircuitBreaker spec CircuitBreaker spec [DO NOT MERGE] May 6, 2026
@tamtamchik tamtamchik requested a review from Copilot May 6, 2026 11:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds documentation for the new CircuitBreaker emergency-pause layer (per LIP-34) and wires it into the Contracts docs navigation, while marking GateSeal as deprecated in favor of CircuitBreaker.

Changes:

  • Adds a new CircuitBreaker contract specification page with roles, parameters, and method/event reference.
  • Updates the Contracts sidebar to include the new CircuitBreaker doc.
  • Adds a deprecation notice to the existing GateSeal documentation pointing readers to CircuitBreaker.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
sidebars.js Adds contracts/circuit-breaker to the Contracts section navigation.
docs/contracts/gate-seal.md Adds a deprecation notice directing users to CircuitBreaker (LIP-34).
docs/contracts/circuit-breaker.md Introduces a full spec/reference page for CircuitBreaker, including addresses and API details.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/contracts/gate-seal.md Outdated
Comment thread docs/contracts/circuit-breaker.md Outdated
Comment thread docs/contracts/circuit-breaker.md Outdated
failingtwice and others added 2 commits May 12, 2026 13:15
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment thread docs/deployed-contracts/index.md
Comment thread docs/deployed-contracts/index.md Outdated
Comment thread docs/contracts/circuit-breaker.md
@failingtwice failingtwice marked this pull request as ready for review June 15, 2026 07:53
@failingtwice failingtwice requested a review from a team as a code owner June 15, 2026 07:53
iamnp
iamnp previously approved these changes Jun 15, 2026

@iamnp iamnp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

tamtamchik
tamtamchik previously approved these changes Jun 15, 2026

@tamtamchik tamtamchik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you! ❤️

Comment thread docs/contracts/circuit-breaker.md
Comment thread docs/contracts/circuit-breaker.md Outdated
Comment thread docs/contracts/circuit-breaker.md
Comment thread docs/contracts/circuit-breaker.md Outdated
Co-authored-by: Yuri Tkachenko <yuri.tam.tkachenko@gmail.com>
@failingtwice failingtwice dismissed stale reviews from tamtamchik and iamnp via b625db3 June 15, 2026 08:56
@failingtwice failingtwice changed the title CircuitBreaker spec [DO NOT MERGE] CircuitBreaker spec Jun 15, 2026
Comment thread docs/contracts/circuit-breaker.md
Comment thread docs/contracts/circuit-breaker.md Outdated

@iamnp iamnp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG!

@tamtamchik tamtamchik merged commit 8e200de into main Jun 15, 2026
1 check passed
@tamtamchik tamtamchik deleted the feat/circuit-breaker branch June 15, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants