[codex] Add ERC20 lock boost provider#822
Draft
skhomuti wants to merge 6 commits into
Draft
Conversation
dgusakov
reviewed
Jun 18, 2026
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
2 times, most recently
from
712c919 to
0407b20
Compare
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
0407b20 to
a8f0f49
Compare
vgorkavenko
reviewed
Jun 24, 2026
|
|
||
| /// @inheritdoc IWeightBoostProvider | ||
| function getWeightBoostBP(uint256 nodeOperatorId) external view returns (uint256 boostBP) { | ||
| boostBP = _getBoostBP(_storage().locks[nodeOperatorId].amount); |
Contributor
There was a problem hiding this comment.
MAX_BP + amount I guess
skhomuti
force-pushed
the
feat/erc20-lock-boost-provider
branch
from
f8c45db to
bd8b09d
Compare
dgusakov
reviewed
Jun 26, 2026
|
|
||
| accounting.grantRole(accounting.MANAGE_BOND_CURVES_ROLE(), address(deployer)); | ||
| accounting.grantRole(accounting.SET_BOND_CURVE_MULTIPLIER_ROLE(), address(additionalBondRegistry)); | ||
| metaRegistry.addWeightBoostProvider( |
Contributor
There was a problem hiding this comment.
Where is LDO lock provider?
|
|
||
| ICuratedModule public immutable MODULE; | ||
| IMetaRegistry public immutable META_REGISTRY; | ||
| address public immutable TOKEN; |
Contributor
There was a problem hiding this comment.
I feel that this provider is already LDO-specific and it makes no sense to name it as general ERC20
|
|
||
| bytes32 public constant SET_LOCK_PERIOD_ROLE = keccak256("SET_LOCK_PERIOD_ROLE"); | ||
|
|
||
| uint256 internal constant MAX_BP = 10000; |
Contributor
There was a problem hiding this comment.
Import from constants lib
| IMetaRegistry public immutable META_REGISTRY; | ||
| address public immutable TOKEN; | ||
| address public immutable VOTING_CONTRACT; | ||
| address public immutable SNAPSHOT_DELEGATION; |
Contributor
There was a problem hiding this comment.
There is a chance that this address might change. Consider having it as a storage variable and fetch the value from the main contract in the vault contracts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary