feat: node operator strikes#832
Draft
vgorkavenko wants to merge 3 commits into
Draft
Conversation
vgorkavenko
force-pushed
the
feat/node-operator-strikes
branch
from
2ef143c to
808e273
Compare
dgusakov
reviewed
Jun 26, 2026
dgusakov
reviewed
Jun 26, 2026
| /// @dev maps a strike id to its position in `active` (0 = not active). | ||
| mapping(uint256 strikeId => uint256 position) index; | ||
| /// @dev on-chain strike description; cleared on removal (empty if removed or never issued). | ||
| mapping(uint256 strikeId => string description) descriptions; |
Contributor
There was a problem hiding this comment.
This can be a part of Strike struct I think
Contributor
Author
There was a problem hiding this comment.
It would increase removing cost because we would need to swap-pop struct with string field
|
|
||
| /// @inheritdoc INodeOperatorStrikes | ||
| function setStrikeThresholds(StrikeThreshold[] calldata thresholds) external onlyRole(DEFAULT_ADMIN_ROLE) { | ||
| _setStrikeThresholds(thresholds); |
Contributor
There was a problem hiding this comment.
We need to invalidateMR weights here
Contributor
Author
There was a problem hiding this comment.
Yeah, there is an addition in natspec that this method should be called along with weights refreshing for operators with strikes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TBDChecklist
just coverage)