-
Notifications
You must be signed in to change notification settings - Fork 129
build: bump lnd to v0.21 #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
build: bump lnd to v0.21 #1153
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ import ( | |
| "strconv" | ||
|
|
||
| "github.com/lightninglabs/loop/looprpc" | ||
| lndcommands "github.com/lightningnetwork/lnd/cmd/commands" | ||
| "github.com/lightningnetwork/lnd" | ||
| "github.com/lightningnetwork/lnd/lnrpc" | ||
| "github.com/urfave/cli/v3" | ||
| ) | ||
|
|
@@ -271,7 +271,7 @@ func openChannel(ctx context.Context, cmd *cli.Command) error { | |
| if cmd.IsSet("utxo") { | ||
| utxos := cmd.StringSlice("utxo") | ||
|
|
||
| outpoints, err := lndcommands.UtxosToOutpoints(utxos) | ||
| outpoints, err := lnd.UtxosToOutpoints(utxos) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just want to note that it was these exact uses of "github.com/lightningnetwork/lnd/cmd/commands" that were the main cause of why |
||
| if err != nil { | ||
| return fmt.Errorf("unable to decode utxos: %w", err) | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,7 +10,7 @@ import ( | |||||
| "github.com/lightninglabs/loop/staticaddr/deposit" | ||||||
| "github.com/lightninglabs/loop/staticaddr/loopin" | ||||||
| "github.com/lightninglabs/loop/swapserverrpc" | ||||||
| lndcommands "github.com/lightningnetwork/lnd/cmd/commands" | ||||||
| "github.com/lightningnetwork/lnd" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Importing
Suggested change
|
||||||
| "github.com/lightningnetwork/lnd/lnrpc" | ||||||
| "github.com/lightningnetwork/lnd/routing/route" | ||||||
| "github.com/urfave/cli/v3" | ||||||
|
|
@@ -192,7 +192,7 @@ func withdraw(ctx context.Context, cmd *cli.Command) error { | |||||
| case isAllSelected: | ||||||
| case isUtxoSelected: | ||||||
| utxos := cmd.StringSlice("utxo") | ||||||
| outpoints, err = lndcommands.UtxosToOutpoints(utxos) | ||||||
| outpoints, err = lnd.UtxosToOutpoints(utxos) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
| if err != nil { | ||||||
| return err | ||||||
| } | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing
"github.com/lightningnetwork/lnd"directly is invalid because the root package oflndispackage main(as it contains the daemon'smain.go), which cannot be imported as a library in Go. This will result in a compilation error. The CLI helperUtxosToOutpointsshould still be imported from"github.com/lightningnetwork/lnd/cmd/commands".