-
Notifications
You must be signed in to change notification settings - Fork 97
LCORE-2914: A2A client support: enable LCS to discover and call external A2A agents #2162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
are-ces
wants to merge
1
commit into
lightspeed-core:main
Choose a base branch
from
are-ces:lcore-2914-a2a-client-discovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Example: A2A remote agent delegation | ||
| # | ||
| # Configures LCS as an orchestrator that can delegate tasks to external | ||
| # A2A-compliant agents. The LLM decides when to delegate based on agent | ||
| # descriptions from their agent cards. | ||
| # | ||
| # See docs/a2a_protocol.md for details. | ||
|
|
||
| name: Lightspeed Orchestrator | ||
| service: | ||
| host: 0.0.0.0 | ||
| port: 8080 | ||
| auth_enabled: false | ||
| llama_stack: | ||
| url: http://localhost:8321 | ||
| api_key: ${env.LLAMA_STACK_API_KEY} | ||
| user_data_collection: | ||
| feedback_enabled: false | ||
| authentication: | ||
| module: "noop" | ||
| inference: | ||
| default_provider: openai | ||
| default_model: gpt-4o-mini | ||
|
|
||
| # Remote A2A agents available for task delegation. | ||
| # At startup, LCS connects to each agent, fetches its agent card, | ||
| # and registers delegation tools with the pydantic-ai agent. | ||
| a2a_agents: | ||
| agents: | ||
| - name: "openshift-agent" | ||
| url: "http://openshift-ls:8082" | ||
| timeout: 30 | ||
| max_retries: 3 | ||
|
|
||
| - name: "ansible-agent" | ||
| url: "http://ansible-ls:8081" | ||
| auth_token: "${env.ANSIBLE_AGENT_TOKEN}" | ||
| timeout: 60 | ||
|
|
||
| - name: "rhel-agent" | ||
| url: "http://rhel-ls:8083" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| """A2A client module for discovering and delegating tasks to external agents.""" | ||
|
|
||
| from a2a_client.capability import A2ADelegationCapability | ||
| from a2a_client.manager import A2AClientManager | ||
|
|
||
| __all__ = [ | ||
| "A2AClientManager", | ||
| "A2ADelegationCapability", | ||
| ] | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Keep this package initializer description-only.
Move these imports to their consumers and remove
__all__.As per coding guidelines, package
__init__.pyfiles must be limited to brief package descriptions.🤖 Prompt for AI Agents
Source: Coding guidelines