fix(webauthn): authorize appid against caller origin#275
Draft
AlfioEmanueleFresta wants to merge 1 commit into
Draft
fix(webauthn): authorize appid against caller origin#275AlfioEmanueleFresta wants to merge 1 commit into
AlfioEmanueleFresta wants to merge 1 commit into
Conversation
…igin Reuse the same-site rp.id check so a caller cannot borrow an unrelated site's legacy AppID on the U2F downgrade path (appid) or to enumerate excluded credentials (appidExclude). The AppID host must be a registrable-domain suffix of, or equal to, the caller origin host. Reject otherwise with a SecurityError, and emit the appidExclude client output when the exclusion is acted upon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The appid and appidExclude extensions were accepted without checking the supplied AppID against the caller, so a site could drive a query under an unrelated AppID. This authorizes the AppID against the caller origin and rejects a mismatch with a security error. The appidExclude result is now reported back when an exclusion is acted on.
Closes #252.