fix(cable): send shutdown and linger for linking data#276
Draft
AlfioEmanueleFresta wants to merge 1 commit into
Draft
fix(cable): send shutdown and linger for linking data#276AlfioEmanueleFresta wants to merge 1 commit into
AlfioEmanueleFresta wants to merge 1 commit into
Conversation
close() now asks the connection loop to send a Shutdown control frame over the encrypted channel and waits for it to terminate before the channel is dropped. After a CTAP response the loop lingers briefly to capture a late linking Update before sending Shutdown and tearing down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On hybrid connections the client never sent a shutdown frame and tore the connection down immediately after the response, dropping any late linking update from the peer. This sends a shutdown on close and lingers briefly to capture a late update.
Part of #257.