fix(webauthn): accept PRF evalByCredential JSON key#277
Open
AlfioEmanueleFresta wants to merge 1 commit into
Open
fix(webauthn): accept PRF evalByCredential JSON key#277AlfioEmanueleFresta wants to merge 1 commit into
AlfioEmanueleFresta wants to merge 1 commit into
Conversation
…er-credential salts The per-credential member deserialized as eval_by_credential instead of the spec name evalByCredential, so conformant JSON callers lost their per-credential salts and the spec validations never ran. Rename it via camelCase, and validate every key in prf_to_hmac_input so a later empty or non-base64url key is still rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON callers scope PRF salts per credential under the member name evalByCredential, but the deserializer only accepted a snake_case key, so the per-credential map was dropped before it could be used. This accepts the spec member name so those salts reach the assertion request.
Closes #251.