test(ctap2): pin canonical CBOR and COSE vectors#279
Open
AlfioEmanueleFresta wants to merge 2 commits into
Open
test(ctap2): pin canonical CBOR and COSE vectors#279AlfioEmanueleFresta wants to merge 2 commits into
AlfioEmanueleFresta wants to merge 2 commits into
Conversation
Characterize the exact wire bytes the CborRequest encode path emits for a fixed MakeCredential and GetAssertion request, and the COSE_Key bytes cosey emits for a fixed P-256 public key. These fail if serde-indexed map ordering or the cosey or serde-indexed byte layout drifts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no test pinning the exact wire bytes the stack emits, so a change in CBOR ordering or a serialization dependency could break interoperability silently. This pins golden vectors for a make-credential and a get-assertion request and for a COSE public key.
Part of #259.