fix(pin): honor PIN policy and normalize PINs#281
Draft
AlfioEmanueleFresta wants to merge 2 commits into
Draft
Conversation
Honor noMcGaPermissionsWithClientPin by routing mc and ga to built-in UV or failing clearly instead of minting a clientPin token. Drive a change-PIN flow when forcePINChange is set before acquiring a PIN-based token. Normalize collected and new PINs to Unicode NFC and check the minimum length in code points while keeping the 63-byte UTF-8 maximum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PIN flow ignored authenticator policy and measured PINs in bytes. This routes operations away from a PIN token when the device forbids it, drives a required PIN change first, and normalizes PINs to NFC with the minimum length checked in code points.
Closes #256.