feat(transport): advertise NFC and hybrid transports#282
Draft
AlfioEmanueleFresta wants to merge 2 commits into
Draft
feat(transport): advertise NFC and hybrid transports#282AlfioEmanueleFresta wants to merge 2 commits into
AlfioEmanueleFresta wants to merge 2 commits into
Conversation
…ransports Add NFC and hybrid/caBLE to the public Transport enum and report compiled-in transports from available_transports. NFC is gated behind the nfc-backend features and hybrid is always present. Thread the active transport from the channel into registration response serialization so the response transports member carries the AuthenticatorTransport token. The list is deduplicated, sorted, and stays empty when the transport is unknown. Both the FIDO2 and U2F-downgrade paths are covered.
AlfioEmanueleFresta
force-pushed
the
feat/advertise-nfc-hybrid-transports
branch
from
b497ec4 to
d834534
Compare
Member
|
@AlfioEmanueleFresta, my read of the WebAuthn spec says that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library implements four transports but advertised only USB and BLE, and registration responses always returned an empty transports list. This adds NFC and hybrid to the public transport list, with NFC shown only when a backend is compiled in, and fills the registration transports from the transport actually used, ordered and deduplicated per the WebAuthn rules.
Closes #258.