Update SDK to support new SIP options.#838
Merged
Merged
Conversation
dennwc
force-pushed
the
sip-update
branch
2 times, most recently
from
fcf8584 to
f76100d
Compare
hechen-eng
approved these changes
Jun 4, 2026
rektdeckard
approved these changes
Jun 8, 2026
Comment on lines
+571
to
+573
| if val, ok := optBoolFlag(cmd, "no-default-codecs"); ok { | ||
| m.OnlyListedCodecs = val | ||
| } |
Member
There was a problem hiding this comment.
Nit: I personally feel like the indirection here doesn't make this simpler.
Suggested change
| if val, ok := optBoolFlag(cmd, "no-default-codecs"); ok { | |
| m.OnlyListedCodecs = val | |
| } | |
| noDefaultCodecsFlag := "no-default-codecs" | |
| if cmd.isSet(noDefaultCodecsFlag) { | |
| m.OnlyListedCodecs = cmd.Bool(noDefaultCodecsFlag) | |
| } |
Contributor
Author
There was a problem hiding this comment.
It doesn't require an extra var with the flag name, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.