simulate: Node agent support, --view mode, and TUI/start UX fixes#878
Open
u9g wants to merge 1 commit into
Open
simulate: Node agent support, --view mode, and TUI/start UX fixes#878u9g wants to merge 1 commit into
u9g wants to merge 1 commit into
Conversation
Ports our simulate work onto the Node-support branch: - Node agent start: normalizeLogLevel, --log-format only for Python, main.ts/main.js entrypoints, and refuse entrypoint discovery when package.json defines a build task; drop the Python-only guard. - `lk agent simulate --view <runID>`: open a pre-existing simulation and print the reopen command on close. - TUI: ←/→ arrow navigation in/out of simulation detail, richer agent-exit errors (start command + recent output), and quit when the agent fails to register.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports our simulate work onto the Node-support branch (
brian/agent-session-node-support). These changes originated on an older fork of the simulate TUI, so they're re-applied as fresh edits rather than cherry-picks.Agent start / Node support
normalizeLogLevelfor the agent's--log-level.--log-format coloredfor Python (the Node CLI rejects it).main.ts/src/main.js(andsrc/fallbacks).package.jsondefines abuildtask and no entrypoint was given (build output paths are nontrivial).lk agent simulate --view <runID>--viewflag /modeViewto open a pre-existing simulation.lk agent simulate --view <runID>) when the TUI closes.TUI UX
→/enterto open a simulation's detail;←/esc/backspaceto go back (hints updated).Intentionally not ported (already present in a different form on this branch): the
exit()/confirmQuitrefactor and thessave-scenario key — this branch has its own save overlay and quit handling.Builds clean with
go buildandgo vet -tags console.