Pin Rust toolchain#1122
Open
ladvoc wants to merge 2 commits into
Open
Conversation
|
Yesterday was part of the six-week release cadence so 1.96.0 is now the most recent stable release, worth updating so that Dependabot doesn't immediately open a PR once this gets merged. Worth also figuring out what y'alls MSRV is, I see #1036 from a month ago mentions this in your PR template. Your biggest dependent crate on crates.io is an optional dependency from Foxglove which has an MSRV of 1.85 since they wanted 2024 Edition; that would probably be the most logical MSRV, but you'd have to actually verify that, your best bet would just to be to add a CI check for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
In a follow up PR, this will be leveraged to improve CI caching.
Closes CLT-2445