Kripke stand-alone umpire build#79
Open
rfhaque wants to merge 8 commits into
Open
Conversation
Collaborator
Author
|
@pearce8 Please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an Umpire-only build to Kripke
ENABLE_CHAI=ON, then the code builds as before using both CHAI and Umpire.ENABLE_CHAI=OFF, but eitherENABLE_CUDA=ONorENABLE_HIP=ON, i.e. for a GPU build, the code builds an Umpire-only version with a device pool. It is important to note that an Umpire-backed CPU build is only possible when using CHAI (as before). A standalone CPU-only Umpire-only build is NOT supportedENABLE_CHAI=ON, the cmake config enables two pragma definitionsKRIPKE_USE_CHAIandKRIPKE_USE_UMPIREENABLE_CHAI=OFF, but eitherENABLE_CUDA=ONorENABLE_HIP=ON, the cmake config enables onlyKRIPKE_USE_UMPIREField.h. As with CHAI, the Umpire-only allocation only allocates storage for an execution space if the code actually touches the data on that space.