Add Android POI filter mapping and styling#82
Closed
dacoto wants to merge 2 commits into
Closed
Conversation
Implement poiEnabled handling for Android: add state and setter, call applyPoiEnabled during map setup, and apply a MapStyleOptions that hides POI and transit when poiEnabled is false. Import MapStyleOptions and keep default=true. Update MAPVIEW.md to clarify that poiEnabled on Android hides POIs and transit stops via map styling.
Refactor Android POI handling by replacing applyPoiEnabled with applyPoiStyle which applies Google Maps style JSON based on poiEnabled, poiFilterCategories and poiFilterMode. Introduce POI_CATEGORY_TO_FEATURE_TYPE mapping and POI_STYLE_HIDE_ALL constant, and support both including and excluding modes (hide all then re-enable selected or hide selected feature types). Update MAPVIEW docs to clarify that Android maps POI categories to Google Maps feature types (coarser granularity). Remove duplicate companion object.
Collaborator
|
Similar to #81, this can be done using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor Android POI handling by replacing applyPoiEnabled with applyPoiStyle which applies Google Maps style JSON based on poiEnabled, poiFilterCategories and poiFilterMode. Introduce POI_CATEGORY_TO_FEATURE_TYPE mapping and POI_STYLE_HIDE_ALL constant, and support both including and excluding modes (hide all then re-enable selected or hide selected feature types). Update MAPVIEW docs to clarify that Android maps POI categories to Google Maps feature types (coarser granularity). Remove duplicate companion object.
Type of Change
Test Plan
Screenshots / Videos
Checklist