Add touch slop and hit-test for marker presses#83
Open
dacoto wants to merge 1 commit into
Open
Conversation
Track touch DOWN/UP to detect taps vs. moves and perform hit-testing to find nearest marker within a configurable radius. Introduces tapDownPoint and earlyFiredMarker to avoid duplicate press events, computes hit center based on marker icon height, and fires a synthetic press via fireMarkerPressIfNearby. Adds TAP_SLOP_PX and HIT_RADIUS_DP constants and updates existing press handling to ignore markers already fired early.
Collaborator
|
@dacoto I'm wondering what's the use-case here and what are you trying to solve/fix? Just want to understand the changes that might affect tap behavior. Do you have some video that I can look? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track touch DOWN/UP to detect taps vs. moves and perform hit-testing to find nearest marker within a configurable radius. Introduces tapDownPoint and earlyFiredMarker to avoid duplicate press events, computes hit center based on marker icon height, and fires a synthetic press via fireMarkerPressIfNearby. Adds TAP_SLOP_PX and HIT_RADIUS_DP constants and updates existing press handling to ignore markers already fired early.
Summary
Type of Change
Test Plan
Screenshots / Videos
Checklist