Validate command headers before dispatch#89
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the VESC app-command receive path by validating the minimum payload length before reading the two-byte command header, preventing out-of-bounds reads on truncated (0–1 byte) packets.
Changes:
- Move the
len < 2guard to run before accessingbuffer[0]/buffer[1]. - Keep existing command dispatch behavior unchanged for valid packets while rejecting too-short payloads early.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject truncated app-command payloads before reading their two-byte header.
The VESC app-data callback can receive zero- or one-byte payloads. The old handler read
buffer[0]andbuffer[1]before checking the length, producing an out-of-bounds read. The old length check then returned forlen < 2, so these packets did not reach command dispatch.The guard now runs before either header byte is accessed.
I was able to eventually get a device reboot from this but it took a lot of packets.