Require Ruby 3.1 and excon 1.5.0 or newer#2
Open
JuniorJoanis wants to merge 3 commits into
Open
Conversation
|
Hello, any reason why you closed your PR ? We have the same issue with the excon upgrade and are currently blocked by this gem, so the PR still seems relevant to me. Did you find another solution ? |
Author
|
Hi @loicginoux , Additionally, my PR required Ruby 3.1.0, and I was concerned that would be a breaking change for anyone still on older Ruby versions. If someone wants to pick this up, a safer fix might just be updating the gemspec: I'm reopening the PR then, hopefully someone from mailchimp will answer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the Ruby client's dependency/support contract from:
to:
That makes
MailchimpTransactionalresolve a patched Excon version by default for consumers affected by current Excon security advisories, while keeping the gem's advertised Ruby support compatible with Excon 1.5.0's own Ruby requirement.Security Advisory
A downstream
bundler-auditrun reported the following issue with the previously resolved Excon version:The advisory solution requires updating Excon to
>= 1.5.0.Why
Downstream applications that need to satisfy security auditing cannot currently combine
MailchimpTransactionalwithexcon >= 1.5.0, because the released gem pins Excon below 1.0.This PR intentionally sets the minimum to
1.5.0rather than only removing the< 1upper bound, so consumers using this branch do not need an additional application-level Excon pin to avoid vulnerable versions.Because Excon 1.5.0 requires Ruby
>= 3.1.0, this PR also raisesrequired_ruby_versionto>= 3.1.0so the gemspec remains internally consistent.Generated repo note
The README says this repository is autogenerated from
mailchimp/mailchimp-client-lib-codegenand asks contributors to submit PRs/issues there. This direct PR is kept as a draft for discussion and for downstream testing of the exact dependency contract needed to resolve the audit finding.This is related to mailchimp/mailchimp-client-lib-codegen#411, but is stricter: that PR removes the Excon upper bound, while this PR requires the patched Excon version directly and updates the Ruby requirement accordingly.
Verification
ASDF_RUBY_VERSION=4.0.5 gem build MailchimpTransactional.gemspecexcon 1.5.0from the gemspec without an explicit Excon pin.MailchimpTransactional::Client#users.ping: passed withexcon 1.5.0.bundle exec bundle-audit check --update:No vulnerabilities found.Notes
This changes only gemspec dependency metadata. The runtime client already uses Excon as its HTTP transport, and the smoke test verified the existing request path with Excon 1.5.0.