Harden completion generation - #3
Closed
malh wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Generated completions could remain pinned to the root context when flags preceded a subcommand, one unsupported advertised command could abort otherwise useful generation, and stdout/stderr each received the full configured output allowance. The write path also lacked crash-durability syncs.
Impact
Help-derived generation is more resilient and nested completion works for common flag-before-command invocations without weakening timeout or output protections.
Validation
go test ./...go vet ./...tests/completionctl-integration.zshtests/help-completion-live.zshgit diff --check