Skip to content

Add persistent directional arrows to task feature LineStrings #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CollinBeczak wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −8
Draft

Add persistent directional arrows to task feature LineStrings #2853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/components/TaskPane/TaskMap/TaskMap.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export const TaskMapContent = (props) => {
};

const features = taskFeatures();
const animator = new MapAnimator();
const animator = useMemo(() => new MapAnimator(), []);

useMapEvents({
moveend: () => {
Expand Down Expand Up @@ -487,7 +487,8 @@ export const TaskMapContent = (props) => {
const markers = [];
const allFeatures = features;
for (const [featureIndex, feature] of allFeatures.entries()) {
if (!feature.properties || !feature.properties.oneway) {
const geometryType = feature.geometry?.type;
if (geometryType !== "LineString" && geometryType !== "MultiLineString") {
continue;
}

Expand All @@ -496,23 +497,26 @@ export const TaskMapContent = (props) => {
props.challenge?.taskStyles,
).getFinalLayerStyles();
const coords = coordAll(feature);
if (["yes", "true", "1"].indexOf(feature.properties.oneway) !== -1) {
for (let i = 0; i < coords.length - 1; i++) {
const isReverse =
feature.properties && ["-1", "reverse"].indexOf(feature.properties.oneway) !== -1;

if (isReverse) {
for (let i = coords.length - 1; i > 0; i--) {
markers.push(
<DirectionalIndicationMarker
key={`directional-marker-${props.task.id}-${featureIndex}-${i}`}
betweenPoints={[point(coords[i]), point(coords[i + 1])]}
betweenPoints={[point(coords[i]), point(coords[i - 1])]}
atMidpoint
styles={styles}
/>,
);
}
} else if (["-1", "reverse"].indexOf(feature.properties.oneway) !== -1) {
for (let i = coords.length - 1; i > 0; i--) {
} else {
for (let i = 0; i < coords.length - 1; i++) {
markers.push(
<DirectionalIndicationMarker
key={`directional-marker-${props.task.id}-${featureIndex}-${i}`}
betweenPoints={[point(coords[i]), point(coords[i - 1])]}
betweenPoints={[point(coords[i]), point(coords[i + 1])]}
atMidpoint
styles={styles}
/>,
Expand Down
Loading