Fix: findPossibleIndexes: RegExp.escape() the symbols#14
Open
domq wants to merge 1 commit into
Open
Conversation
|
|
domq
added a commit
to epfl-si/ATARI
that referenced
this pull request
Feb 6, 2026
This prevents a Meteor compiler crash when processing a module that exports a symbol named `$`. See: meteor/reify#14
Author
|
Meh — |
Fixes meteor#13 This prevents an infinite loop for e.g. modules that export a variable named `$`. In Node 24.x we could use `RegExp.escape()`, but that doesn't exist in Node 22.x which Meteor 3.4.0 uses. Provide a polyfill
domq
force-pushed
the
fix/export-dollar
branch
from
February 6, 2026 15:30
2298902 to
b6e3ca3
Compare
Author
|
I unfortunately can't seem to change the PR title now 😐😐 |
domq
added a commit
to epfl-si/ATARI
that referenced
this pull request
Feb 11, 2026
This prevents a Meteor compiler crash when processing a module that exports a symbol named `$`. See: meteor/reify#14
Author
|
Can you please review this PR? Many thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13
This prevents an infinite loop for e.g. modules that export a variable named
$.