Fix: Adjust heap-allocate accelerator table to avoid release-build startup#12
Open
electricmessiah wants to merge 1 commit into
Open
Fix: Adjust heap-allocate accelerator table to avoid release-build startup#12electricmessiah wants to merge 1 commit into
electricmessiah wants to merge 1 commit into
Conversation
…rash CreateAcceleratorTableW(&accels)? intermittently failed with 'Invalid access to memory location (0x800703E6)' in --release builds once the local ACCEL array reached 35 entries, while debug builds never reproduced it at any size. Confirmed size-dependent (any 34-entry array worked, content-independent) and optimizer-dependent (only --release), consistent with a stack-layout-sensitive miscompilation rather than a logic bug. Moving the array to the heap (.to_vec()) sidesteps it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateAcceleratorTableW(&accels)? intermittently failed with 'Invalid access to memory location (0x800703E6)' in --release builds once the local ACCEL array reached 35 entries, while debug builds never reproduced it at any size. Confirmed size-dependent (any 34-entry array worked, content-independent) and optimizer-dependent (only --release), consistent with a stack-layout-sensitive miscompilation rather than a logic bug. Moving the array to the heap (.to_vec()) sidesteps it.