Fix: left right duplication#70
Open
samuelzxu wants to merge 3 commits into
Open
Conversation
) makeLeftRight typeset the inner math list twice — once to size the delimiters and once to place the content. Typesetting an MTMathList is not idempotent: preprocessMathList fuses adjacent ordinary atoms in place via MTMathAtom.fuse (nucleus += atom.nucleus), so the second pass re-fused already-fused runs and duplicated any multi-atom content inside a \left…\right group. Nesting compounded the effect (one extra pass per level). Typeset the inner list once, cache the resulting MTMathListDisplay, and reuse it for both the delimiter-height calculation and placement. Adds LeftRightDuplicationTests covering the issue mgriebling#66 reporter expression plus fraction, bracket, nested, and \left. variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inner content of
\left(and\right)should be typeset at most once to avoid duplication errors.Thanks for maintaining this tool! I use it in my repo and found this issue with it which was already open.
Fixes #66