Skip to content

Michael Myaskovsky via Elementary: Rename tag: finance → fin#240

Open
elementary-data-local[bot] wants to merge 1 commit into
mainfrom
elementary-modify-assets-metadata-20260722105835386691
Open

Michael Myaskovsky via Elementary: Rename tag: finance → fin#240
elementary-data-local[bot] wants to merge 1 commit into
mainfrom
elementary-modify-assets-metadata-20260722105835386691

Conversation

@elementary-data-local

Copy link
Copy Markdown

Elementary: This PR updates your dbt assets according to changes made in Elementary's UI.


Created by: michael@elementary-data.com

@github-actions

Copy link
Copy Markdown

Tag Rename: financefin

⚠️ Breaking tag change — affects 4 models but has broader blast radius

The diff renames the finance tag to fin across orders, returned_orders, stg_orders, and stg_payments. However, Elementary currently shows 9 models carrying the finance tag — including artificial_anomaly, date_based_anomaly, returned_orders_anomaly, forced_anomaly, and return_rate_anomaly (all in models/schema.yml). Those 5 models are not updated in this PR, meaning after merge the codebase will have an inconsistent mix of finance and fin tags.

Risks:

  • Any alert routing rules, filters, or dashboards scoped to the finance tag will stop matching the 4 updated models immediately on merge.
  • The 5 unmodified models retain finance, so tag-based queries will return split/incomplete results.
  • If fin is a new tag (not an existing one), any downstream consumers expecting finance get nothing.

Recommendation: Either update all 9 finance-tagged models in this PR, or revert to keeping finance as-is. If this rename is intentional, it should be a single atomic change covering the whole project and any dependent alert/routing configurations.


Risk: Medium — No SQL logic or schema changes; purely metadata. Low breakage risk to pipelines, but tag-based filtering and alerting will be silently inconsistent after merge.

Posted by Elementary CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants