colors: Add blink, dim and strikethrough to the colorscheme attributes#4126
Open
JoeKar wants to merge 2 commits into
Open
colors: Add blink, dim and strikethrough to the colorscheme attributes#4126JoeKar wants to merge 2 commits into
blink, dim and strikethrough to the colorscheme attributes#4126JoeKar wants to merge 2 commits into
Conversation
dmaluka
reviewed
Jul 16, 2026
|
|
||
| func TestMultiAttributesStringToStyle(t *testing.T) { | ||
| s := StringToStyle("bold italic underline cyan,brightcyan") | ||
| s := StringToStyle("bold blink dim italic reverse strikethrough underline cyan,brightcyan") |
Collaborator
There was a problem hiding this comment.
If I remove strikethrough from this string, the test still passes. What am I doing wrong?
Member
Author
There was a problem hiding this comment.
Nothing, but you uncovered a type "conflict" which doesn't fail on negative evaluation.
We have two options:
- positive comparison against the same type
- negative comparison against the type cast to
int, which doesn't fail compared against0
…type Otherwise assert.NotEqual() still passes since the attributes type is not int.
JoeKar
force-pushed
the
feature/style-attributes
branch
from
July 17, 2026 08:01
c294f28 to
49894a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4125