fix: remove run-setup.yml (causes sync drift by committing directly to public main)#773
Closed
brandom-msft wants to merge 1 commit into
Closed
fix: remove run-setup.yml (causes sync drift by committing directly to public main)#773brandom-msft wants to merge 1 commit into
brandom-msft wants to merge 1 commit into
Conversation
This workflow regenerates azuredeploy.json from main.bicep on push-to-main, creating commits on public that don't exist on private. This breaks the private-to-public sync marks, causing nightly sync failures. Regeneration is owned by the private repo's copy of this workflow, and the compiled ARM output flows to public via the normal sync pipeline. Refs: https://github.com/microsoft-foundry/foundry-samples-pr/actions/runs/27332078723 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
👋 Thanks for your contribution, @brandom-msft! This repository is read-only. If you are contributing on behalf of Microsoft, please submit your PR to the private staging repository instead: See CONTRIBUTING.md for full instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The run-setup.yml workflow on public triggers on push to main and regenerates azuredeploy.json files from Bicep sources. When a sync PR lands a commit that touches infrastructure/infrastructure-setup-bicep/, this workflow fires and commits regenerated ARM JSON directly to public main — creating a commit that doesn't exist on private.
This breaks the nightly private-to-public sync because the marks become stale (they reference objects from a tree state that no longer matches), and seed-marks recovery correctly refuses to paper over the divergence.
Evidence
Fix
Delete the workflow from public entirely. Regeneration is owned by private; compiled ARM flows to public via the sync pipeline.
After this merges, we'll merge the pending auto/regenerate-azuredeploy-59ecf811 branch on private and re-trigger sync with seed_from_public_sha to re-anchor marks.
Also needed on private (separate PR)
Remove run-setup.yml from sync-config.json's protected_paths list — it no longer needs protection since it won't exist on public.