Skip to content

Fix P0 local-auth and ACR DNS defaults #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shrutiyer wants to merge 1 commit into from
Closed

Fix P0 local-auth and ACR DNS defaults #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...e/infrastructure-setup-bicep/16-private-network-standard-agent-apim-setup/main.bicepparam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ param existingDnsZones = {
'privatelink.search.windows.net': ''
'privatelink.blob.core.windows.net': ''
'privatelink.documents.azure.com': ''
'privatelink.azurecr.io': ''
'privatelink.azure-api.net': ''
}

Expand All @@ -44,6 +45,7 @@ param dnsZoneNames = [
'privatelink.search.windows.net'
'privatelink.blob.core.windows.net'
'privatelink.documents.azure.com'
'privatelink.azurecr.io'
'privatelink.azure-api.net'
]

Expand All @@ -54,4 +56,3 @@ param dnsZoneNames = [
param vnetAddressPrefix = ''
param agentSubnetPrefix = ''
param peSubnetPrefix = ''

2 changes: 1 addition & 1 deletion ...ivate-network-standard-agent-apim-setup/modules-network-secured/ai-account-identity.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ resource account 'Microsoft.CognitiveServices/accounts@2025-04-01-preview' = {
}
] : null )
// Set disable local auth to true or false. Agent service does not support API key based authentication
disableLocalAuth: false
disableLocalAuth: true
}
}

Expand Down
5 changes: 3 additions & 2 deletions ...etup-bicep/17-private-network-standard-user-assigned-identity-agent-setup/main.bicepparam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ param existingDnsZones = {
'privatelink.cognitiveservices.azure.com': ''
'privatelink.search.windows.net': ''
'privatelink.blob.core.windows.net': ''
'privatelink.documents.azure.com': ''
'privatelink.documents.azure.com': ''
'privatelink.azurecr.io': ''
}

//DNSZones names for validating if they exist
Expand All @@ -41,6 +42,7 @@ param dnsZoneNames = [
'privatelink.search.windows.net'
'privatelink.blob.core.windows.net'
'privatelink.documents.azure.com'
'privatelink.azurecr.io'
]


Expand All @@ -67,4 +69,3 @@ param dnsZoneNames = [
param vnetAddressPrefix = ''
param agentSubnetPrefix = ''
param peSubnetPrefix = ''

2 changes: 1 addition & 1 deletion ...dard-user-assigned-identity-agent-setup/modules-network-secured/ai-account-identity.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ resource account 'Microsoft.CognitiveServices/accounts@2025-04-01-preview' = {
}
] : null )
// Set disable local auth to true or false. Agent service does not support API key based authentication
disableLocalAuth: false
disableLocalAuth: true
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...-setup-bicep/18-managed-virtual-network/modules-network-secured/ai-account-identity.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ resource account 'Microsoft.CognitiveServices/accounts@2025-10-01-preview' = {
useMicrosoftManagedNetwork: true
}
]
disableLocalAuth: false
disableLocalAuth: true
}
}

Expand Down
1 change: 1 addition & 0 deletions infrastructure/infrastructure-setup-bicep/19-private-network-agent-tools/main.bicepparam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,6 @@ param existingDnsZones = {
'privatelink.search.windows.net': { subscriptionId: '', resourceGroup: '' }
'privatelink.blob.core.windows.net': { subscriptionId: '', resourceGroup: '' }
'privatelink.documents.azure.com': { subscriptionId: '', resourceGroup: '' }
'privatelink.azurecr.io': { subscriptionId: '', resourceGroup: '' }
'privatelink.fabric.microsoft.com': { subscriptionId: '', resourceGroup: '' }
}
2 changes: 1 addition & 1 deletion ...up-bicep/19-private-network-agent-tools/modules-network-secured/ai-account-identity.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ resource account 'Microsoft.CognitiveServices/accounts@2025-04-01-preview' = {
}
]
: null)
disableLocalAuth: false
disableLocalAuth: true
}
}

Expand Down
Loading