feat: add contains/minContains/maxContains members#2876
Merged
Conversation
baywet
requested changes
Jun 9, 2026
baywet
reviewed
Jun 9, 2026
baywet
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes!
Added a couple more comments
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall coverage in the branch remains at 88%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Updated |
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
baywet
previously approved these changes
Jun 9, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
baywet
approved these changes
Jun 9, 2026
MIchaelMainer
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds the JSON Schema 2020-12 array keywords
contains,maxContains, andminContainsto the Schema Object, as required by the OpenAPI 3.1/3.2 specifications.Type of Change
Related Issue(s)
Closes #2875 #2875
Changes Made
Contains(IOpenApiSchema?),MaxContains(int?), andMinContains(int?) members toIOpenApiSchema,OpenApiSchema, andOpenApiSchemaReference, pluscontains/maxContains/minContainsconstants inOpenApiConstants.WriteJsonSchemaKeywords(emitted for OpenAPI 3.1+ only; dropped on 3.0/2.0 downcast, consistent withdependentRequired).PublicAPI.Unshipped.txtwith the new public surface.Testing
Checklist
Versions applicability
See the contributing guidelines for more information about how patches are applied across multiple versions.
Additional Notes