MAINT: Minor pyrit.model module reorganization #1999
Open
rlundeen2 wants to merge 1 commit into
Open
Conversation
Move ScenarioResult into pyrit.models.results and ConversationReference / ChatMessage into pyrit.models.messages. These symbols are re-exported from pyrit.models, so the canonical import stays `from pyrit.models import X` and no deprecation shim is needed at the old submodule paths. Switch all external consumers and tests to the short-form package-root import per the style guide, keep same-package imports on the specific module to avoid cycles, and clarify that ChatMessage is the OpenAI Chat Completions wire shape (distinct from the domain Message/MessagePiece). Adds a dedicated Conversation model test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rlundeen2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving some modules around to where they make sense. Deprecation seemed more confusing than helpful since everything is imported from the base.