test(marketplace): cover registered ref install flow#1994
Open
abhinavgautam01 wants to merge 1 commit into
Open
test(marketplace): cover registered ref install flow#1994abhinavgautam01 wants to merge 1 commit into
abhinavgautam01 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new integration-tier test that exercises the end-to-end apm install <plugin>@<marketplace> flow to ensure a registered marketplace --ref is propagated all the way through resolution, persistence (apm.yml / lockfile), and into the downloader boundary for both GitHub-family and GitLab marketplaces.
Changes:
- Introduces a hermetic integration test that stubs only external I/O seams (marketplace fetch/cache, existence probe, downloader) while running the rest of the install pipeline on production code.
- Verifies
--refpropagation for both dependency persistence formats:- GitHub-family string dependency form
- GitLab structured
{git, path, ref}dependency form
- Asserts clone URL components via
urllib.parse.urlparse(component-level checks rather than substring assertions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds integration-tier coverage for marketplace registered
--refpropagation through the full install path.This covers the follow-up from #1918 by exercising
apm install plugin@marketplacethrough marketplace resolution, dependency parsing, manifest persistence, lockfile writing and the downloader boundary. The test verifies both GitHub-family and GitLab marketplace flows, including the structured GitLabgit+pathdependency shape.Fixes #1918
Type of change
Testing
Validation run:
Results:
Spec conformance (OpenAPM v0.1)
If this PR changes behaviour that an OpenAPM v0.1 req-XXX covers,
confirm the three-step ritual (see CONTRIBUTING.md "Adding or
changing a normative requirement"):
Spec edit: docs/src/content/docs/specs/openapm-v0.1.md updated
(new/changed anchor + prose + Appendix C
row).
Manifest edit: docs/src/content/docs/specs/manifests/openapm-v0.1.requirements.yml
updated.
Test edit: a @pytest.mark.req("req-XXX") test under
tests/spec_conformance/ added or extended.
CONFORMANCE.{md,json} regenerated via
uv run --extra dev python -m tests.spec_conformance.gen_statement
and committed.
N/A -- this PR does not change OpenAPM-observable behaviour.