Clean up the remaining workaround of fast_fwd.h#1582
Open
YexuanXiao wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes the leftover WINRT_EXPORT workaround from the base_fast_forward.h string template used to generate winrt/fast_forward.h, reverting module-v2-specific adjustments that are no longer intended to be kept.
Changes:
- Drops the local fallback
#ifndef WINRT_EXPORT/#define WINRT_EXPORTblock in the template. - Stops using
WINRT_EXPORTon thewinrt::implnamespace in the generatedfast_forward.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the module v2's modifications to this file, as those changes are meaningless. I originally introduced these changes in my own branch, and they were inherited by module v2. Supporting fastabi with the winrt module requires further modifications to base_fast_forward.h and the generator, so there is no need to keep them for now.