libicu autodetect doesn't work in Ubuntu14.04#876
Open
psalic wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
DHowett
requested changes
Jun 15, 2026
DHowett
left a comment
DHowett
left a comment
Member
There was a problem hiding this comment.
Can you explain a little more in depth how this works? We thought you could just set EDIT_CFG_ICUUC_SONAME and friends in any build environment on any version of any Linux distribution. Why is that insufficient on Ubuntu 14.04? (Also: that version is 12 years old, I'm surprised someone is still using it!)
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
It showed that libicu autodetect doesn't work in Ubuntu14.04. I made a fix that solves the issue.
I found that same code can be compiled with apple compiler which would fail. That is reason I added cfg depend.
Otherwise I also made fix for macos if someone likes to use with homebrew licicu. I attach full patch_full.txt.
It compiles with command:
EDIT_CFG_ICUUC_SONAME="libicuuc.dylib" EDIT_CFG_ICUI18N_SONAME="libicui18n.dylib" EDIT_CFG_ICU_RENAMING_AUTO_DETECT="true" RUSTFLAGS="-C link-arg=-Wl,-rpath,/opt/homebrew/opt/icu4c/lib" cargo build --releaseRegards, Primoz