Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Fix page titles and add microsoft favicon#112

Open
elrmndo wants to merge 9 commits into
microsoft:masterfrom
elrmndo:master
Open

Fix page titles and add microsoft favicon#112
elrmndo wants to merge 9 commits into
microsoft:masterfrom
elrmndo:master

Conversation

@elrmndo

@elrmndo elrmndo commented Mar 10, 2019

Copy link
Copy Markdown
Contributor

Added titles to the pages and somewhat added a favicon w/c is the microsoft logo from microsoft.com

@micahgodbolt

Copy link
Copy Markdown
Member

not familiar with that favicon URL. Can you try to find an official version?

@micahgodbolt micahgodbolt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update favicon

@micahgodbolt

Copy link
Copy Markdown
Member

Also, it looks like you checked in a TON of changes that are simply whitespace updates. Can you only submit actual code changes. git add -p helps

@ahtee

ahtee commented Mar 11, 2019

Copy link
Copy Markdown

wouldn't hurt to import an svg or official icon into the assets dir

@elrmndo

elrmndo commented Mar 12, 2019

Copy link
Copy Markdown
Contributor Author

i actually got the favicon from the microsoft website anws, i'll be changing it and add an svg in the assets folder, also i might be reverting it back and redo the changes

i wasn't really also sure what caused the reformatting, i would also try to check on that

@elrmndo

elrmndo commented Mar 12, 2019

Copy link
Copy Markdown
Contributor Author

actually found out that series of white spaces/auto format occurred w/o me having prettier extension installed in vscode so when I save, it auto formats with a bunch of spaces 😟

@ahtee

ahtee commented Mar 12, 2019

Copy link
Copy Markdown

actually found out that series of white spaces/auto format occurred w/o me having prettier extension installed in vscode so when I save, it auto formats with a bunch of spaces 😟

can you turn off prettier in vscode and try to revert those changes?

@elrmndo

elrmndo commented Mar 13, 2019

Copy link
Copy Markdown
Contributor Author

actually found out that series of white spaces/auto format occurred w/o me having prettier extension installed in vscode so when I save, it auto formats with a bunch of spaces 😟

can you turn off prettier in vscode and try to revert those changes?

I actually did the other way around and committed a better version of it at 6aa2825

@elrmndo elrmndo left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the favicon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants