Skip to content

build: Android compileSdk 34 + UWP ARM64 warning + Linux WSC test dl … #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v-patrickpe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Android compileSdk 34 + UWP ARM64 warning + Linux WSC test dl … #985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Build/libHttpClient.Android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apply plugin: "com.android.library"

android {
compileSdkVersion 31
compileSdkVersion 34
ndkVersion "27.2.12479018"

defaultConfig {
Expand Down
1 change: 1 addition & 0 deletions Build/libHttpClient.Linux/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ if (HC_ENABLE_WEBSOCKET_COMPRESSION AND NOT HC_NOWEBSOCKETS)
PRIVATE
"${PROJECT_NAME}"
Threads::Threads
${CMAKE_DL_LIBS} # Required for dlopen/dlsym referenced by linked libcrypto in some configurations
)

if (NOT BUILD_SHARED_LIBS)
Expand Down
1 change: 1 addition & 0 deletions Samples/UWP-Http/Http.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<ItemDefinitionGroup>
<ClCompile>
<PreprocessorDefinitions>_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">false</TreatWarningAsError>
</ClCompile>
</ItemDefinitionGroup>
<ItemGroup>
Expand Down